-
Notifications
You must be signed in to change notification settings - Fork 242
Fix function build errors not rendering actual failure reason #7216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -288,6 +288,11 @@ export class AppEventWatcher extends EventEmitter { | |
| }) | ||
| } else { | ||
| this.options.stderr.write(error.message) | ||
| if (error.tryMessage) { | ||
| this.options.stderr.write( | ||
| typeof error.tryMessage === 'string' ? error.tryMessage : String(error.tryMessage), | ||
| ) | ||
| } | ||
|
Comment on lines
+291
to
+295
|
||
| } | ||
|
|
||
| // Update all events for this extension with error result | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When printing
error.messageand thenerror.tryMessage, the two writes are concatenated with no separator, so users may see a single glued string (e.g.,Failed to build function.Command failed ...). Consider writing a newline (or\n\n) between them, or only adding a separator iferror.messagedoesn’t already end with one, so the output is readable.