E2E: QA - app basic flow#7211
Open
phyllis-sy-wu wants to merge 1 commit intopsyw-0402-E2E-cleanup-utilityfrom
Open
E2E: QA - app basic flow#7211phyllis-sy-wu wants to merge 1 commit intopsyw-0402-E2E-cleanup-utilityfrom
phyllis-sy-wu wants to merge 1 commit intopsyw-0402-E2E-cleanup-utilityfrom
Conversation
This was referenced Apr 7, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e35703a to
62f553f
Compare
14613f3 to
f902ebd
Compare
62f553f to
3d3c531
Compare
f902ebd to
1899bb0
Compare
3d3c531 to
b31e3b2
Compare
1899bb0 to
a91fa51
Compare
a91fa51 to
98fd534
Compare
b31e3b2 to
5daa312
Compare
5daa312 to
33c9916
Compare
98fd534 to
0460404
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/ui.d.ts import { Logger, LogLevel } from '../../public/node/output.js';
-import React from 'react';
import { Key, RenderOptions } from 'ink';
import { EventEmitter } from 'events';
-/**
- * Signal that the current Ink tree is done. Must be called within an
- * InkLifecycleRoot — throws if the provider is missing so lifecycle
- * bugs surface immediately instead of silently hanging.
- */
-export declare function useComplete(): (error?: Error) => void;
-/**
- * Root wrapper for Ink trees. Owns the single `exit()` call site — children
- * signal completion via `useComplete()`, which sets state here. The `useEffect`
- * fires post-render, guaranteeing all batched state updates have been flushed
- * before the tree is torn down.
- */
-export declare function InkLifecycleRoot({ children }: {
- children: React.ReactNode;
-}): React.JSX.Element;
interface RenderOnceOptions {
logLevel?: LogLevel;
logger?: Logger;
renderOptions?: RenderOptions;
}
export declare function renderOnce(element: JSX.Element, { logLevel, renderOptions }: RenderOnceOptions): string | undefined;
-export declare function render(element: JSX.Element, options?: RenderOptions): Promise<void>;
+export declare function render(element: JSX.Element, options?: RenderOptions): Promise<unknown>;
export declare class Stdout extends EventEmitter {
columns: number;
rows: number;
readonly frames: string[];
private _lastFrame?;
constructor(options: {
columns?: number;
rows?: number;
});
write: (frame: string) => void;
lastFrame: () => string | undefined;
}
export declare function handleCtrlC(input: string, key: Key, exit?: () => void): void;
export {};
packages/cli-kit/dist/public/node/ui.d.ts@@ -34,7 +34,7 @@ export interface RenderConcurrentOptions extends PartialBy<ConcurrentOutputProps
* 00:00:00 │ frontend │ third frontend message
*
*/
-export declare function renderConcurrent({ renderOptions, ...props }: RenderConcurrentOptions): Promise<void>;
+export declare function renderConcurrent({ renderOptions, ...props }: RenderConcurrentOptions): Promise<unknown>;
export type AlertCustomSection = CustomSection;
export type RenderAlertOptions = Omit<AlertOptions, 'type'>;
/**
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
This implements the Apps section of the CLI pre-release QA checklist as an automated E2E test. The test exercises the full app lifecycle from scratch — no pre-provisioned apps, no fixed
SHOPIFY_FLAG_CLIENT_ID.WHAT is this pull request doing?
New test:
app-basic-flow.spec.tsA single end-to-end test covering the core QA flow in 9 steps:
createApp(reactRouter, typescript)app devvia PTYapp execute --queryqapp dev cleanapp deploy --versionapp versions list --jsonapp config linkapp deploy --config secondaryKey characteristics:
--organization-idsetup/app.ts:createApp,deployApp,versionsList,extractClientId,configLink,teardownAppcli.spawnfor interactiveapp devandcli.execfor non-interactive commandsfinally(withE2E_SKIP_CLEANUPsupport)QA checklist coverage:
shopify app devapp executeqto stop devshopify app dev cleanshopify app deployshopify app versions listshopify app config link(new app)How to test your changes?
Measuring impact
Checklist