Skip to content

Remove stored auth test storage casts#8106

Merged
alfonso-noriega merged 1 commit into
mainfrom
maintenance/stored-auth-test-types
Jul 17, 2026
Merged

Remove stored auth test storage casts#8106
alfonso-noriega merged 1 commit into
mainfrom
maintenance/stored-auth-test-types

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes none.

The stored auth summary tests repeated storage as any casts, which obscured the intended test storage type and made malformed-storage setup harder to distinguish from normal typed calls.

WHAT is this pull request doing?

Adds typed test helpers for store-auth local storage and raw malformed bucket setup, then replaces the repeated as any casts in stored-auth.test.ts.

How to test your changes?

  • pnpm --filter @shopify/store vitest run src/cli/services/store/auth/stored-auth.test.ts
  • pnpm --filter @shopify/store lint

Note: pnpm --filter @shopify/store type-check was attempted locally but failed on existing @shopify/organizations module resolution errors unrelated to this test-only diff.

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Assisted-By: devx/992f9535-2b53-46c8-a775-0fc7a7bc2eb5
@alfonso-noriega alfonso-noriega changed the title Tighten store list BP test types Remove stored auth test storage casts Jul 16, 2026
@alfonso-noriega
alfonso-noriega marked this pull request as ready for review July 16, 2026 09:24
@alfonso-noriega
alfonso-noriega requested a review from a team as a code owner July 16, 2026 09:24

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 16, 2026
@alfonso-noriega
alfonso-noriega added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit 1ba92e2 Jul 17, 2026
30 checks passed
@alfonso-noriega
alfonso-noriega deleted the maintenance/stored-auth-test-types branch July 17, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants