Implement the Kill Collector mechanic

[Chris443C]

Kill Collectors were cosmetic only: a CreatureTitle, a CreatureState and some FigLeafData, with no kill counting, no threshold, no XP grant and no persistence. This implements the mechanic end to end.

Behaviour

Kills accrue whether or not the player has ever met the collector, which is what makes the reward retroactive. Talking to a collector pays out min(accumulated, cap) - claimed, opens an NPC dialogue window, and shows the orange turn-in marker while anything is owed.

The claim is advanced before XP is granted, so a partial failure cannot pay the same kills twice, and accrual stops writing to the database once a collector is exhausted.

Schema

Table	Database
kill_collector_definitions	World	132 collectors: kill cap, XP per kill, optional completion ToK unlock
kill_collector_targets	World	312 creature entries that credit a collector
characters_kill_collector	Characters	per-character accumulated / claimed / rewarded

Migrations are split by target database and each states which in its header.

Targets are creature entries, not Bestiary subtypes

22 of the 132 collectors want creatures spanning more than one CreatureSubType, and even within a subtype only some variants qualify, so the Bestiary counter cannot express them. TokInterface.AddKill is unchanged and remains a separate concern.

KillCollectorService builds a creature -> collectors reverse index at load, so the kill path costs one dictionary lookup and never scans the 132 definitions. Non-target creatures return a shared empty list and allocate nothing.

Where the data came from

Collector, quest, target label, kill cap and XP come from Return of Reckoning's public GraphQL API, which resolves all 132 NPCs with Title = 32. It returns a human-readable target label and no creature ids, so entries were resolved against creature_protos scoped to each collector's own zones:

• 106 resolved by zone-scoped exact name match
• 22 hand-mapped where the label names a camp or faction rather than a mob
• 4 have no matching creature in this world data and are seeded inert, with no targets, listed at the end of the migration

Deliberate decisions

• Caps are data. Seeded values are current RoR's 20-60 by chapter; retail is documented as 60 for every collector. Changing that is a row edit.
• Not a quest. RoR implements these as repeatable quests. Retail did not, and the difference is behavioural: quest objectives only count kills made after acceptance, which loses the retroactive credit the client's own tip text describes. Reasoning is recorded in docs/kill-collector.md.
• No influence message. Retail printed a spurious "you have received an influence reward" line on maxing a collector. No influence was granted; it was cosmetic. Not reproduced.
• RoR's modern rewards are not imported. Current RoR gives dyes and consumables on a standardised schedule; that is RoR balancing, not retail behaviour. CompletionTokEntry is seeded 0.

Not included

Map pips (MAPPIPS_KILL_COLLECTOR_*) remain unreferenced.

Testing

Built clean against master (zero errors or warnings) and verified in game: retroactive credit, partial claiming, cap arithmetic, the turn-in icon on spawn, and the dialogue window. The repository has no test project, so docs/kill-collector.md carries a manual checklist instead.

One implementation note worth knowing for anyone touching quest icons: the head icon has to be set in two places, in two different enums. Creature.SendMeTo holds an inline copy of GetQuestStatusFor's if/else chain and never calls the method, so patching only QuestsInterface compiles, reads correctly, and does nothing.

Also included

• docs/gm-teleport-reference.md - teleports to every collector and its target mobs, plus every battlefield objective. Written for testing this, useful beyond it.
• docs/known-issues/open-items.md - unrelated problems found along the way, kept rather than discarded. The notable one: 294 of 1352 gameobject quest objectives reference entries absent from gameobject_protos, making 223 quests uncompletable - the same gap that aborts PQ spawn loops.

Happy to drop either doc if they do not belong in a feature PR.

🤖 Generated with Claude Code