Release v1.2.1: ship fixed package when AMO signing fails - #25
Merged
Conversation
Create the GitHub Release before AMO/CWS store steps and keep those steps non-blocking so a bad AMO JWT can no longer prevent shipping the fixed package (v1.2.0 never published for this reason). Co-authored-by: Julius Walton <ShiosOS@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.2.0 never appeared on GitHub Releases because the AMO signing step failed (
Unknown JWT iss) beforegh release createran. That left the broken v1.1.0 zip (missingchecks.js) as latest.Changes
continue-on-errorso bad credentials cannot block shipping.xpiafterward when AMO signing succeedsfailuresstatus-match fix already onmain)Shipped
v1.2.1 is live (tag pushed; workflow created the release with
checks.jspresent in the zip).AMO signing still fails with the current JWT secrets (non-blocking). The published
.xpiis therefore unsigned — Chromium Load unpacked from the.zipis the supported path until AMO credentials are fixed. Chrome Web Store secrets are not configured.Verification
npm test— 79 passedchecks.jsandpages.js