Skip to content

Match plural "failures" in FAILING_RE check-status pattern #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShiosOS merged 1 commit into from
Jul 14, 2026
Merged

Match plural "failures" in FAILING_RE check-status pattern #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion checks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
// name that itself contains a standalone status word (e.g. "error-pages")
// is still ambiguous — labels are all GitHub's accessible rows give us.
const FAILING_RE =
/\b(fail(?:ed|ing|ure|s)?|error(?:ed|s)?|timed out|cancel(?:l?ed)?|denied|action required)\b/i;
/\b(fail(?:ed|ing|ures?|s)?|error(?:ed|s)?|timed out|cancel(?:l?ed)?|denied|action required)\b/i;
const RUNNING_RE = /\b(in[ _]progress|pending|queued|running|waiting|expected)\b/i;
const PASSING_RE = /\b(success(?:ful)?|passed|passing)\b/i;

Expand Down
1 change: 1 addition & 0 deletions test/checks.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ describe("deriveChecksState", () => {
it("still matches the real inflected status phrases", () => {
expect(deriveChecksState(["ci failed after 2m"]).key).toBe("failing");
expect(deriveChecksState(["ci failure"]).key).toBe("failing");
expect(deriveChecksState(["ci 2 failures"]).key).toBe("failing");
expect(deriveChecksState(["deploy cancelled after 10s"]).key).toBe("failing");
expect(deriveChecksState(["deploy canceled after 10s"]).key).toBe("failing");
expect(deriveChecksState(["lint timed out"]).key).toBe("failing");
Expand Down