Open
Conversation
AxenoDev
requested changes
Apr 19, 2026
|
|
||
| public static void saveMayorConstant() { | ||
| try { | ||
| if (phaseMayor != 1 && phaseMayor != 2) { |
Member
There was a problem hiding this comment.
Tu peux pas faire un phaseMayor > 2 ?
Member
Author
There was a problem hiding this comment.
si je fais ça, si la phase et = a 0, ça va quand meme enregistrer.
Puis je trouve plus lisible de mettre le numéro des 2 phases (mais encore plus si je supprimerais les int pour les phases et que je metterais le systeme dans une enum)
| } | ||
|
|
||
| phaseMayor = constant.getPhase(); | ||
| if (constant.getPhase() != 1 && constant.getPhase() != 2) { |
Member
There was a problem hiding this comment.
Tu peux pas faire un constan.getPhase() > 2 ?
Puis mets le content.getPhase() en variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petit résumé de la PR:
Une phase était initialisé a 0, une phase qui n'existe pas.
J'ajoute juste des fallback au cas ou ça viendrait a se reproduire
Étape nécessaire afin que la PR soit fini (si PR en draft)
Decrivez vos changements