Rewrite OMCPlugin + Reorganisation packages#1243
Open
iambibi wants to merge 15 commits intoServerOpenMC:masterfrom
Open
Rewrite OMCPlugin + Reorganisation packages#1243iambibi wants to merge 15 commits intoServerOpenMC:masterfrom
iambibi wants to merge 15 commits intoServerOpenMC:masterfrom
Conversation
Member
Author
|
Je n'attaquerais pas le rewrite des registres, a vrai dire je ne sais pas si c'est si utile que ça. PR Ouverte. Peut etre review et si y'a des avis sur l'organisation des packages je prends |
AxenoDev
previously approved these changes
Apr 19, 2026
Member
|
L'orga pour moi est bien, possible de merge ou pas ? |
Member
Author
|
je vais faire les conflits, ça peut etre fini apres manger |
# Conflicts: # src/main/java/fr/openmc/core/OMCPlugin.java # src/main/java/fr/openmc/core/features/dream/generation/DreamBiome.java # src/main/java/fr/openmc/core/features/dream/mecanism/metaldetector/MetalDetectorListener.java # src/main/java/fr/openmc/core/features/dream/models/db/DreamPlayer.java # src/main/java/fr/openmc/core/features/dream/registries/items/tools/MetalDetector.java # src/main/java/fr/openmc/core/utils/database/DatabaseManager.java
Member
Author
|
@AxenoDev tu peux faire passer celle la, apres je module ma pr sur les boss bar, et tu pourras merge celle avec les boss bar dcp |
Member
Author
|
a ça a fail |
This was
linked to
issues
Apr 26, 2026
Member
Author
|
je travaille aussi sur la possibilité de pouvoir lancer omc sans item adder |
…e chargent et qui ne sont pas trouvé)
…chargent dans le LuckPermsHook, donc si je mets l'interface qui exclu la feature si le hook n'est pas activé, ben ça mets class not found pour LuckPerms)
Member
Author
|
PR prete a etre merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petit résumé de la PR:
J'ai ajouté un handler pour les Features, j'ai plus sécurisé avec un boolean qui dit si la feature est correctement initialisé afin de pouvoir se save (car si save clear la table et que init ne s'est pas executer = table vide).
Réorganisation des packages utils
Correctif des majeures erreurs lorsqu'il n'y a pas items adder (fin affinage du mode debug initialement appelé comme cela)
Étape nécessaire afin que la PR soit fini (si PR en draft)
Decrivez vos changements