fix(github): update source_metadata state field instead of signals.status#51
Merged
Merged
Conversation
…atus UpdateGitHubIssueState was writing 'open'/'closed' into the signals.status column which is reserved for read/unread/archived workflow state. Instead, update the state key inside the source_metadata JSON using SQLite replace() so the dashboard correctly reflects the open/closed state after toggling. Fixes Sentinent-AI/Sentinent#35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "close issue from dashboard" bug (Sentinent-AI/Sentinent#35).
Problem
UpdateGitHubIssueStatewas writing'open'/'closed'into thesignals.statuscolumn, which is reserved for the read/unread/archived workflow state. This meant the toggle call appeared to succeed (200 from GitHub API) but the local signal record was never updated correctly, so the card state didn't change on refresh.Fix
Instead of updating
signals.status, the handler now updates the"state"key inside thesource_metadataJSON using SQLite'sreplace()function, scoped to the matching signal byuser_id,workspace_id,source_type = 'github', and the issue number pattern in the metadata.Files changed
services/github.go