Skip to content

[AMD] dsv4-fp4-mi355x-sglang: switch fixed-seq-len search space to TP4#1768

Open
seungrokj wants to merge 9 commits into
mainfrom
amd/dsv4_sgl_0616
Open

[AMD] dsv4-fp4-mi355x-sglang: switch fixed-seq-len search space to TP4#1768
seungrokj wants to merge 9 commits into
mainfrom
amd/dsv4_sgl_0616

Conversation

@seungrokj

@seungrokj seungrokj commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Switch dsv4-fp4-mi355x-sglang fixed-seq-len search space from TP8 to TP4 for both isl=1024 and isl=8192 scenarios
  • Expand isl=8192 coverage: add TP4 dp-attn sweep (conc 32–2048) alongside TP4 TP-only sweep (conc 1–32)
  • Update perf-changelog.yaml with change description

Test plan

  • Verify dsv4-fp4-mi355x-sglang fixed-seq-len CI jobs launch with TP4 configs
  • Confirm isl=8192 dp-attn and TP-only rows both appear in sweep results

🤖 Generated with Claude Code


Note

Low Risk
YAML-only benchmark sweep tuning; no application or serving code paths change.

Overview
Updates dsv4-fp4-mi355x-sglang fixed-seq-len benchmark sweeps on MI355X: the former TP8, dp-attn off latency rows (conc 1–32) are replaced with TP4 coverage—dp-attn on (conc 16–128) and dp-attn off (conc 1–32)—for both isl=1024 and isl=8192. The existing TP8 + dp-attn high-concurrency rows (conc 64–2048) are unchanged.

Documents the change in perf-changelog.yaml for config key dsv4-fp4-mi355x-sglang.

Reviewed by Cursor Bugbot for commit 64213b9. Bugbot is set up for automated code reviews on this repo. Configure here.

seungrokj and others added 3 commits June 15, 2026 11:35
…ter yaml

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…able isl=1024 and expand isl=8192

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… space update

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

@seungrokj seungrokj added the AMD label Jun 15, 2026

@functionstackx functionstackx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seungrokj can u try looking into sgl mtp too? would switching it help? +viz @1am9trash

Comment thread .github/configs/amd-master.yaml Outdated
…dp-attn conc=512 point

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 50b4a94. Configure here.

Comment thread .github/configs/amd-master.yaml Outdated
seungrokj and others added 4 commits June 15, 2026 13:34
…oint for dsv4-fp4-mi355x-sglang

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…n and TP4 TP-only rows for isl=1024 and isl=8192

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

@seungrokj

Copy link
Copy Markdown
Collaborator Author

@functionstackx @cquil11 can you plz approve this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants