Add options to override default extra_body and num_prompts when profiler is enabled#1044
Open
devalshahamd wants to merge 4 commits intoSemiAnalysisAI:mainfrom
Open
Add options to override default extra_body and num_prompts when profiler is enabled#1044devalshahamd wants to merge 4 commits intoSemiAnalysisAI:mainfrom
devalshahamd wants to merge 4 commits intoSemiAnalysisAI:mainfrom
Conversation
…abled Signed-off-by: Deval Shah <devashah@amd.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
devalshahamd
changed the title
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for customizing the profiling request body in the benchmark serving scripts by introducing a new
--profile-extra-bodyparameter. This allows users to pass additional profiling options as a JSON string, improving flexibility for advanced profiling scenarios. The changes update both the shell and Python benchmarking utilities to support and propagate this new option.Profiling customization support:
benchmarks/benchmark_lib.sh: Added a--profile-extra-bodyargument torun_benchmark_serving()and ensured it is passed to the benchmark command if provided. [1] [2] [3]utils/bench_serving/benchmark_serving.py: Added a--profile-extra-bodyargument to the CLI, parsed it as a JSON string, and passed it to the benchmark logic. If not specified, a default is used. [1] [2] [3] [4]utils/bench_serving/benchmark_serving.py: Updated the profiling request to use the providedprofile_extra_bodyinstead of hardcoded values.Profiling behavior improvements:
benchmarks/benchmark_lib.sh: Made the number of profiling prompts configurable via thePROFILE_NUM_PROMPTSenvironment variable, instead of always usingmax_concurrency.Both changes are additional and backward compatible. The new behavior is enabled only when explicitly set.