Skip to content

[py][build] Update bazel rules_python#17403

Open
cgoldberg wants to merge 5 commits into
SeleniumHQ:trunkfrom
cgoldberg:py-bump-rules-python
Open

[py][build] Update bazel rules_python#17403
cgoldberg wants to merge 5 commits into
SeleniumHQ:trunkfrom
cgoldberg:py-bump-rules-python

Conversation

@cgoldberg
Copy link
Copy Markdown
Member

@cgoldberg cgoldberg commented Apr 28, 2026

💥 What does this PR do?

Bump bazel rules_python to 2.0.1 (no toolchain version upgrades in this release)

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

🔄 Types of changes

  • Build

@cgoldberg cgoldberg self-assigned this Apr 28, 2026
@cgoldberg cgoldberg added C-py Python Bindings B-build Includes scripting, bazel and CI integrations labels Apr 28, 2026
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Apr 28, 2026

Review Summary by Qodo

(Agentic_describe updated until commit 553f0a3)

Bump bazel rules_python to 2.0.1

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Bump bazel rules_python from 1.9.0 to 2.0.1
• Updates MODULE.bazel dependency configuration
Diagram
flowchart LR
  A["rules_python 1.9.0"] -- "version upgrade" --> B["rules_python 2.0.1"]
  B -- "MODULE.bazel" --> C["Updated dependency"]
Loading

Grey Divider

File Changes

1. MODULE.bazel Dependencies +1/-1

Upgrade rules_python dependency version

• Updated rules_python bazel dependency from version 1.9.0 to 2.0.1
• No other dependencies modified

MODULE.bazel


Grey Divider

Qodo Logo

@cgoldberg
Copy link
Copy Markdown
Member Author

ugh... upgrading to rules_python 2.0.0 breaks the build.

I documented this at: #17404
This needs to be fixed before we can merge this.

@cgoldberg cgoldberg marked this pull request as draft April 28, 2026 22:30
@cgoldberg cgoldberg marked this pull request as ready for review May 15, 2026 14:15
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 15, 2026

Persistent review updated to latest commit 553f0a3

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 15, 2026

Persistent review updated to latest commit 5c5a924

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 15, 2026

Persistent review updated to latest commit d044864

@SeleniumHQ SeleniumHQ deleted a comment from qodo-code-review Bot May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant