Add --resource flag for RFC 8707 Resource Indicators#152
Open
kevinmdb wants to merge 1 commit intoSecureAuthCorp:masterfrom
Open
Add --resource flag for RFC 8707 Resource Indicators#152kevinmdb wants to merge 1 commit intoSecureAuthCorp:masterfrom
kevinmdb wants to merge 1 commit intoSecureAuthCorp:masterfrom
Conversation
Adds support for the OAuth 2.0 `resource` request parameter (RFC 8707) on the authorization, token, PAR, and device authorization endpoints. Multiple resource indicators are sent as repeated `resource=` parameters per the spec, rather than a single space-joined value. Includes unit tests covering empty, single, and multi-value cases for both AuthorizeRequest and RequestToken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the OAuth 2.0
resourcerequest parameter(RFC 8707 — Resource Indicators)
to oauth2c. Mirrors the existing
--audienceplumbing.--resourceflag (StringSlice, repeatable like--audience)Resource []stringfield onClientConfigrequest bodies/queries
resource=parameters per RFC 8707§2 (rather than space-joining), so
--resource A --resource Bproducesresource=A&resource=BTest plan
go test ./...passes (new unit tests ininternal/oauth2/request_test.gocover empty / single / multiple resource values for both
AuthorizeRequestand
RequestToken)go build ./...cleangolangci-lint runclean--resource <uri>shows up in the GET to/authorizequery paramsand the POST to
/tokenform body