ty_utils: allow UnsafeBinder and Pat in async/sync drop glue allowlists#612
Open
SebTardif wants to merge 1 commit into
Open
ty_utils: allow UnsafeBinder and Pat in async/sync drop glue allowlists#612SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
AsyncDropInPlace instance resolution omitted UnsafeBinder (and Pat) while DropGlue already accepted UnsafeBinder. Align both allowlists with needs_drop component handling. Closes #611 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #611
Summary
AsyncDropInPlacenontrivial instance resolution rejectedty::UnsafeBinder(andty::Pat) withOk(None)while syncDropGluealready allowedUnsafeBinder. AddUnsafeBinderandPatto both allowlists so they match compound handling used byneeds_drop_components(Pat peels; UnsafeBinder is a component).Origin
80c0b7e90fd0Test plan