Fix codegen and macro edge cases - #3158
Merged
Merged
Conversation
Huliiiiii
reviewed
Aug 5, 2026
Author
Author
Member
|
I'd like to merge the macro hygiene part first. Could you split the new CLI flag changes into a separate PR? |
Author
|
Per your request, I split PR #3158: this branch now only contains macro-hygiene changes, while CLI flag changes were moved to a separate branch (commit ac991a3). I鈥檒l open a follow-up PR from that branch for the CLI part when you want. Net diff for this PR is now: [sea-orm-macros/src/derives/active_enum.rs, ... , sea-orm-macros/tests/derive_entity_model_column_name_test.rs]. |
Author
|
Done. I split PR #3158 into two branches and opened a follow-up PR for CLI flag work.
Original PR review fix (DbErr signature tweak) remains in this PR. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FromQueryResult/model identifier collisions with fields namedroworpreErrorValidation
cargo test -p sea-orm-macros --test derive_active_enum_test --test derive_entity_model_column_name_testcargo test --manifest-path sea-orm-cli/Cargo.toml --lib test_generate_entity_skips_postgres_partial_unique_constraints