Fix schema-sync indexes for Postgres schemas#3085
Open
ouywm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
Bug Fixes
Fix schema-sync generated indexes for entities in non-default PostgreSQL schemas.
Schema-sync can already discover and match tables in non-default PostgreSQL schemas after entity sync does not work with postgres when tables have schemas defined #2952 / Fix schema sync not discovering tables in non-default schemas #3016. However, indexes generated from entity attributes still used the unqualified table name.
For an entity declared with
#[sea_orm(schema_name = "sys", table_name = "app_user")], generated index DDL could targetON "app_user"instead ofON "sys"."app_user". When the connection'ssearch_pathstill resolves unqualified table names inpublic, sync can fail withrelation "app_user" does not exist, or target a same-named table in the wrong schema.Breaking Changes
Changes
Entity::table_ref()for generated index targets on PostgreSQL, soschema_nameis included when present.#[sea_orm(indexed)]and multi-column#[sea_orm(unique_key = "...")]in a non-default PostgreSQL schema.sea-orm-sync.