fix: env var SCRAPEGRAPHAI_TELEMETRY_ENABLED had no effect - #1123
Open
m-waqar-tahir wants to merge 1 commit into
Open
fix: env var SCRAPEGRAPHAI_TELEMETRY_ENABLED had no effect#1123m-waqar-tahir wants to merge 1 commit into
m-waqar-tahir wants to merge 1 commit into
Conversation
dosubot
Bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1118
What was wrong
_check_config_and_environ_for_telemetry_flag() checked whether
SCRAPEGRAPHAI_TELEMETRY_ENABLED was set in the environment, but then read
the telemetry value from the config file again instead of the actual
environment variable. As a result, setting the env var had no effect.
Fix
Read the environment variable's actual string value and convert it to a
boolean directly, instead of re-reading from the config object.
Testing
Verified locally:
SCRAPEGRAPHAI_TELEMETRY_ENABLED=false uv run python -c "from scrapegraphai.telemetry.telemetry import is_telemetry_enabled; print(is_telemetry_enabled())"
Output: False (previously returned True)