Skip to content

Handle URLs in GetFileContentType and add null check #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yileicn merged 2 commits into from
May 7, 2026
Merged

Handle URLs in GetFileContentType and add null check #1346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ead1fb
Handle URLs in GetFileContentType and add null check
May 7, 2026
062ad78
Merge branch 'SciSharp:master' into master
adenchen123 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Infrastructure/BotSharp.Abstraction/Files/Utilities/FileUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,19 @@ public static BinaryData BuildBinaryDataFromFile(IFormFile file)

public static string GetFileContentType(string fileName)
{
if (string.IsNullOrEmpty(fileName))
{
return string.Empty;
}

// For URLs (e.g. signed S3/CloudFront URLs with query strings), extract the path portion
// so that FileExtensionContentTypeProvider can correctly resolve the extension.
if (Uri.TryCreate(fileName, UriKind.Absolute, out var uri)
&& (uri.Scheme == Uri.UriSchemeHttp || uri.Scheme == Uri.UriSchemeHttps))
{
fileName = uri.AbsolutePath;
}

string contentType;
var provider = new FileExtensionContentTypeProvider();
if (!provider.TryGetContentType(fileName, out contentType))
Expand Down
Loading