Fix variable-rate jumps for DAE problems - #627
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
VR_FRMextended a DAE'su0with the integrated jump-intensity states but leftdu0at its original size, so constructing the resultingDAEProblemthrew a size mismatch. The DAE wrapper also still used DDE-style function signatures instead of the SciML DAE residual interface.This extends
du0anddifferential_vars, evaluates the augmented equations asdu_jump - rate(u, p, t) = 0, and preserves the inputDAEFunctionspecialization policy. The regression test covers in-place and out-of-place residual evaluation underFullSpecialize; it also solves the in-place problem withDFBDF.The OrdinaryDiffEqBDF addition is test-only. It is MIT-licensed and adds no runtime dependency.
Regression evidence
The same official test fails with
src/variable_rate.jlrestored to the unfixed version:With this commit applied:
The historical boundary was bisected to a336dc6, which introduced the DAE
remakewith an extendedu0but notdu0. The original hybrid-problem work at #72 requested DAE coverage but did not add it.Verification
Local
GROUP=QAcurrently reports 16 passed and 1 failed on both this branch and cleanupstream/master: SciMLTesting 2.4 enabled the public-reexport check without a repository allowlist. The independent fix is #623; it passes 17/17 locally on SciMLTesting 2.4 and 2.7. That mechanical QA change is intentionally not bundled here, so this PR's CI QA job is expected to remain red until that prerequisite merges.CI reproduced only that expected failure: 16/17, with
No unapproved public reexportsas the sole failure in https://github.com/SciML/JumpProcesses.jl/actions/runs/31543893598/job/93952232035.Not verified
I did not run InterfaceII, GPU, Julia prerelease, or the full
Everythingmatrix locally. The out-of-place DAE residual is evaluated directly by the regression test; an out-of-placeDFBDFcallback solve is not claimed because that solver configuration does not currently provide the callback's temporary-cache interface.No documentation build was run because this changes no public API, docstring, or rendered documentation.
Links