Target the DiffEqDevTools monorepo test project#213
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Target the DiffEqDevTools monorepo test project#213ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
The remaining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Audit finding
The downstream workflow still cloned the archived standalone
DiffEqDevTools.jlrepository and selectedAll. DiffEqDevTools is now registered fromOrdinaryDiffEq.jl:lib/DiffEqDevTools, whose focused group isCoreand whose direct runner readsODEDIFFEQ_TEST_GROUP. The workflow also caught resolver errors and converted them to success.Changes
OrdinaryDiffEq.jland activatelib/DiffEqDevTools;Coregroup throughODEDIFFEQ_TEST_GROUP;Regression_Irow;Local verification
.github/workflows/Downstream.yml.OrdinaryDiffEq/Regression_I: exit 0; OrdinaryDiffEq tests passed.DiffEqDevTools/Core: exit 0. Final sets included Plot Recipes 36/36 and nonlinear-solve work-precision diagrams 6/6; Pkg reportedDiffEqDevTools tests passed.git diff --checkpassed.An earlier
Allrun exposed unrelated pre-existing QA/documentation coverage failures; those are being handled separately in SciML/OrdinaryDiffEq.jl#3906. This workflow now requests only the intended populated Core group.