Skip to content

WIP: Start GPU porting#278

Draft
EmilyBourne wants to merge 26 commits into
mainfrom
ebourne_gradual_gpu_port_part_1
Draft

WIP: Start GPU porting#278
EmilyBourne wants to merge 26 commits into
mainfrom
ebourne_gradual_gpu_port_part_1

Conversation

@EmilyBourne
Copy link
Copy Markdown
Collaborator

This PR is not ready to review but I want to check the cuda compiler output as the output on GPU is not verbose enough

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@EmilyBourne EmilyBourne marked this pull request as draft May 20, 2026 11:23
@EmilyBourne EmilyBourne marked this pull request as ready for review May 20, 2026 12:19
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 99.69372% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.77%. Comparing base (a87782a) to head (9c83c51).

Files with missing lines Patch % Lines
include/GMGPolar/setup.h 90.00% 1 Missing ⚠️
include/GMGPolar/utils.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   95.73%   95.77%   +0.04%     
==========================================
  Files          79       79              
  Lines        8492     8575      +83     
==========================================
+ Hits         8130     8213      +83     
  Misses        362      362              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julianlitz julianlitz self-requested a review May 20, 2026 13:06
julianlitz
julianlitz previously approved these changes May 20, 2026
@EmilyBourne
Copy link
Copy Markdown
Collaborator Author

@julianlitz
WIP = Work In Progress
This PR does not yet run correctly on GPU. I took it out of draft temporarily to check if the problem is also present in the modified CPU version

@EmilyBourne EmilyBourne dismissed julianlitz’s stale review May 20, 2026 13:11

Review left on unfinished modifications

@EmilyBourne EmilyBourne marked this pull request as draft May 20, 2026 13:12
@julianlitz
Copy link
Copy Markdown
Collaborator

image
"Ready to review" 😊😉
I just approved it so you don't habe to wait until someone approves it. You can just leave it unmerged and request a second review when you think you are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants