Reject writable file commands after close or abort - #916
Merged
Merged
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
The macOS 12 package CTest
webscene_native_file_system_accessreachedFileSystemWritableFileStream.write()after a successful atomicclose()and did not reject withTypeError. The directwrite,seek, andtruncatemethods checked only stream identity before queuing into the generic WritableStream. They now reject when the native transaction has already been cleared by close or abort, without reopening or mutating the file.Focused gate
The existing native File System Access fixture now checks all three commands after both close and abort, retaining the atomic commit and rollback byte assertions.
git diff --checkpasses. Run thewebscene_native_file_system_accessCTest and related native runtime CI on this exact head before merge; the local V8/SDK build cache was removed during requested artifact cleanup. Full macOS package CTest failures in other subsystems remain tracked by #914.Closes #915. Related owner: #248.