Split IndexedDB bootstrap below the MSVC literal limit - #307
Merged
Merged
Conversation
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The IndexedDB compatibility bootstrap is one 19,859-byte raw C++ literal. MSVC rejects individual string-literal tokens above its C2026 limit, which breaks the Windows native package before any IndexedDB tests can run.
Change
std::string_viewbyte-for-byteValidation
/std:c++20 /W4 /WXheader compile passed with the exact header blob in this rebased commita3c907644e9b6c9d63eddfbd6a591802e99bbd3249a3b1437788ce4eb1c73b64git diff --checkThis fixes the independent Windows C2026 package failure and does not change IndexedDB behavior.
Closes #301