Make retained inset parsing portable on macOS - #306
Merged
Merged
Conversation
wieslawsoltes
force-pushed
the
fix/inset-number-portability-302
branch
2 times, most recently
from
September 17, 2026 18:14
eed7806 to
9131e5c
Compare
This was referenced Sep 17, 2026
wieslawsoltes
force-pushed
the
fix/inset-number-portability-302
branch
from
September 17, 2026 18:24
9131e5c to
6582b22
Compare
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The retained inset clip parser uses floating-point
std::from_chars. Apple libc++ only exposes that overload on newer macOS deployment targets, so the current WebScene package fails to compile for the supported macOS target.Change
px,%, unitless-zero, sign, decimal, and exponent formsValidation
CMAKE_OSX_DEPLOYMENT_TARGET=12.0and V8 disabledgit diff --checkThis PR addresses the macOS package compile failure only. Linux CSS timing failures remain tracked in #238, and the independent Windows IndexedDB literal failure remains tracked in #301.
Closes #302