Fix frontend CI build break by aligning SimulationFrame type with visualizer usage - #96
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job frontend
Fix frontend CI build break by aligning Aug 2, 2026
SimulationFrame type with visualizer usage
Sanan507
marked this pull request as ready for review
August 2, 2026 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
frontendGitHub Actions job failed during TypeScript build becauseCanvasVisualizerreadsframe.comparing, butSimulationFramedid not define that field. This PR updates the shared frame type so the existing visualization logic type-checks correctly.Type contract alignment
comparing?: number[]toSimulationFrameinfrontend/src/models/types.ts.highlightwhile supporting code paths already usingcomparing.Why this unblocks CI
TS2339inCanvasVisualizer.tsxwithout changing runtime behavior.