Skip to content

fix(UART_ReceptionToIdle_CircularDMA): wrap old_pos to fix silent data loss #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
94xhn wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

fix(UART_ReceptionToIdle_CircularDMA): wrap old_pos to fix silent data loss #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Projects/STM32446E-Nucleo/Examples/UART/UART_ReceptionToIdle_CircularDMA/Src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,11 @@ void HAL_UARTEx_RxEventCallback(UART_HandleTypeDef *huart, uint16_t Size)
pBufferReadyForReception = ptemp;
}
/* Update old_pos as new reference of position in User Rx buffer that
indicates position to which data have been processed */
old_pos = Size;
indicates position to which data have been processed.
Size can be equal to RX_BUFFER_SIZE (not wrapped to 0) when the
Transfer Complete event reports a full circular buffer, so it must be
wrapped here to stay a valid index into aRXBufferUser. */
old_pos = Size % RX_BUFFER_SIZE;

}

Expand Down