Replace umockdev with vfido for passkey testing

[ikerexxe]

Migrate the passkey testing infrastructure from umockdev to vfido, providing a more robust and reliable solution for passkey authentication testing. The migration includes updating client feature detection to support vfido's requirements, refactoring authentication utilities for improved integration, and updating the documentation to reflect the new vfido usage patterns. These changes enhance the overall passkey testing experience while maintaining backward compatibility where applicable.

SSSD PRCI run for these changes is available in SSSD/sssd#8510

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request migrates the passkey testing infrastructure to use vfido instead of umockdev. This change provides a more reliable and maintainable solution for testing passkey authentication. The update includes necessary code modifications and documentation updates to ensure a smooth transition and maintain backward compatibility where possible.

Highlights

• Migration: Migrated passkey testing infrastructure from umockdev to vfido for a more robust solution.
• Feature Detection: Updated client feature detection to support vfido requirements.
• Refactoring: Refactored authentication utilities for improved integration with vfido.
• Documentation: Updated documentation to reflect the new vfido usage patterns.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• docs/guides/testing-passkey.rst
  • Updated documentation to reflect the migration from umockdev to vfido for passkey testing, including system requirements and usage examples.
• sssd_test_framework/hosts/client.py
  • Modified client feature detection to accurately identify vfido support by checking for the vhci_hcd kernel module and the vfido.py executable.
• sssd_test_framework/roles/ipa.py
  • Corrected the return value processing in run_expect to retrieve the correct output line.
• sssd_test_framework/utils/authentication.py
  • Refactored passkey authentication utilities to use vfido instead of umockdev, including updates to handle PIN prompts and device touch simulation.

Activity

• Migration of passkey testing infrastructure from umockdev to vfido.
• Updating client feature detection to support vfido requirements.
• Refactoring authentication utilities for improved integration.
• Updating documentation to reflect the new vfido usage patterns.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request migrates the passkey testing infrastructure from umockdev to vfido, which is a more modern and robust solution. The changes are well-structured, covering documentation, feature detection, and the authentication utilities themselves. I've identified a few areas for improvement, mainly around documentation consistency and simplifying some of the expect scripts for better readability and maintenance.

[madhuriupadhye]

Does the fallback-to-password scenario always require a PIN?