Use fixed-width types in SQLite::Header - #582
Merged
Merged
Conversation
SRombauts
force-pushed
the
abi-header-fixed-width-types
branch
2 times, most recently
from
September 22, 2026 15:34
d23f662 to
7b23aae
Compare
SRombauts
force-pushed
the
abi-header-fixed-width-types
branch
2 times, most recently
from
September 22, 2026 15:54
69b48c4 to
b7769b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::uint8_tandstd::uint32_tforSQLite::HeaderfieldsRationale
This reintroduces the public type change from #558 that #575 intentionally deferred to preserve the 3.4.0 ABI.
SQLite database-header fields have defined byte widths. Using fixed-width integer types makes those widths independent of the platform data model, notably avoiding 64-bit
unsigned longfields on LP64 systems. The existing UB-free big-endian parsing remains unchanged.Testing
The existing
Database.getHeaderInfotest covers the parsed values. Compile-time assertions cover every publicHeaderfield type.The same code change previously passed the full CI matrix. The branch has now been rebased onto
masterafter the shared-library ABI generation was bumped from 0 to 1 in both CMake and Meson, and CI is revalidating that final state.