fix(clickhouse): support multi-gateway projects with catalog-aware engines#5826
Open
mday-io wants to merge 3 commits into
Open
fix(clickhouse): support multi-gateway projects with catalog-aware engines#5826mday-io wants to merge 3 commits into
mday-io wants to merge 3 commits into
Conversation
…gines ClickHouse's UNSUPPORTED catalog_support caused 2-level FQNs that broke sqlglot MappingSchema when mixed with 3-level FQNs from Trino or other catalog-aware gateways. Fix: auto-inject a virtual catalog (gateway name) for UNSUPPORTED adapters when catalog-aware peers exist, then strip it before any SQL reaches ClickHouse. Signed-off-by: mday-io <mdaytn@gmail.com>
mday-io
force-pushed
the
fix/clickhouse-multi-gateway-catalog-support
branch
from
b1435d7 to
89696e5
Compare
mday-io
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When adding a ClickHouse gateway to a project that already has a catalog-aware gateway (catalog.schema.table) (e.g. Trino), SQLMesh throws an error.
The issue is that sqlglot's
MappingSchemaexpects all models to use the same FQN depth. ClickHouse doesn't have a catalog concept so its models are 2-level (db.table), while Trino models are 3-level (catalog.db.table). SQLMesh doesn't handle the mix — registering models from both gateways causes a nesting mismatch.Found this by accident: plan worked fine after manually adding a fake third tier to ClickHouse model references, which confirmed the mismatch was the culprit.
The fix injects the gateway name as a virtual catalog for ClickHouse, bumping its models up to 3-level FQNs internally so they match. The virtual catalog is stripped before anything hits the wire, so ClickHouse never sees it.
Note: Projects that previously used ClickHouse as a single gateway and now add a catalog-aware gateway will see ClickHouse models re-materialized once. Their FQNs transition from 2-level to "3-level", which changes their fingerprints.
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO