Minor fix for Windows web UI interface#4752
Open
codetalker-ai wants to merge 15 commits into
Open
Conversation
…nd" in UI "Source Code" tab
Collaborator
|
We'll hold off merging this for a bit, need to ensure that our testing coverage on main is sufficient to avoid any regressions. |
|
Wow, this finally makes the sqlmesh ui work for me on Windows. It never worked before, it would always say it couldn't find any file I clicked on. I hope it gets merged in, I'll put it in my private patches for now. |
Collaborator
|
@codetalker-ai can you rebass your branch and push it again? It looks like there is some conflict. Once it passes tests we can merge it |
Collaborator
|
@codetalker-ai Just following up on my last comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows OS running UI will render Source Code to be "File not found" since relative path on Windows is two backslashes
\\, while SQLMesh uses POSIX format.Aligned relative path to be POSIX format as well.