Feature 14230 mumps disease changes - #14245
Merged
Merged
Conversation
7 tasks
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughAdds Mumps disease configuration and reference data, persists Mumps reporting exclusion and contact pregnancy fields, extends disease defaults, and updates case/contact forms plus disease styling. ChangesMumps medical data
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant CaseCreateForm
participant CaseDataDto
participant CaseFacadeEjb
participant Case
participant Database
CaseCreateForm->>CaseCreateForm: show reportingExcluded for MUMPS
CaseCreateForm->>CaseDataDto: submit reportingExcluded
CaseDataDto->>CaseFacadeEjb: provide case data
CaseFacadeEjb->>Case: set reportingExcluded
Case->>Database: persist reportingexcluded
Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@sormas-api/src/main/java/de/symeda/sormas/api/Disease.java`:
- Line 101: Update the MUMPS entry in Disease to set defaultFollowUpDuration to
25, matching defaultMaxIncubationPeriod and ensuring contact follow-up covers
the full incubation window.
In `@sormas-ui/src/main/java/de/symeda/sormas/ui/caze/CaseCreateForm.java`:
- Around line 599-605: Keep reportingExcluded synchronized with disease changes:
in CaseCreateForm’s disease visibility logic, clear the reportingExcluded value
when hiding the field for non-Mumps diseases. In CaseDataForm’s disease-change
listener, update the field visibility whenever the disease changes and clear
reportingExcluded outside Mumps; apply these changes at
sormas-ui/src/main/java/de/symeda/sormas/ui/caze/CaseCreateForm.java lines
599-605 and sormas-ui/src/main/java/de/symeda/sormas/ui/caze/CaseDataForm.java
line 734.
In `@sormas-ui/src/main/java/de/symeda/sormas/ui/contact/ContactDataForm.java`:
- Around line 584-594: Update the male branch in ContactDataForm’s trimester
visibility logic to clear CaseDataDto.TRIMESTER along with the existing
sex-inapplicable fields before or while hiding it. Ensure male contacts cannot
retain or submit values for postpartum, pregnant, or trimester, while preserving
the current visibility behavior for non-male contacts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a987e689-aed2-4eff-b090-11abea244674
📒 Files selected for processing (17)
sormas-api/src/main/java/de/symeda/sormas/api/Disease.javasormas-api/src/main/java/de/symeda/sormas/api/caze/CaseDataDto.javasormas-api/src/main/java/de/symeda/sormas/api/contact/ContactDto.javasormas-api/src/main/java/de/symeda/sormas/api/i18n/Captions.javasormas-api/src/main/resources/enum.propertiessormas-backend/src/main/java/de/symeda/sormas/backend/caze/Case.javasormas-backend/src/main/java/de/symeda/sormas/backend/caze/CaseFacadeEjb.javasormas-backend/src/main/java/de/symeda/sormas/backend/contact/Contact.javasormas-backend/src/main/java/de/symeda/sormas/backend/contact/ContactFacadeEjb.javasormas-backend/src/main/java/de/symeda/sormas/backend/disease/DiseaseConfigurationFacadeEjb.javasormas-backend/src/main/resources/sql/sormas_schema.sqlsormas-ui/src/main/java/de/symeda/sormas/ui/caze/CaseCreateForm.javasormas-ui/src/main/java/de/symeda/sormas/ui/caze/CaseDataForm.javasormas-ui/src/main/java/de/symeda/sormas/ui/contact/ContactController.javasormas-ui/src/main/java/de/symeda/sormas/ui/contact/ContactDataForm.javasormas-ui/src/main/java/de/symeda/sormas/ui/utils/CssStyles.javasormas-ui/src/main/webapp/VAADIN/themes/sormas/views/disease.scss
# Conflicts: # sormas-backend/src/main/resources/sql/sormas_schema.sql
raulbob
approved these changes
Jul 30, 2026
# Conflicts: # sormas-api/src/main/resources/captions.properties # sormas-api/src/main/resources/enum.properties # sormas-backend/src/main/resources/sql/sormas_schema.sql # sormas-ui/src/main/java/de/symeda/sormas/ui/utils/CssStyles.java # sormas-ui/src/main/webapp/VAADIN/themes/sormas/views/disease.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Summary by CodeRabbit