Skip to content

Removed the case reference date from the filter and defaulted the rep… - #14236

Open
KarnaiahPesula wants to merge 1 commit into
developmentfrom
bugfix-13968-filter-for-date-in-case-directory-not-working-properly
Open

Removed the case reference date from the filter and defaulted the rep…#14236
KarnaiahPesula wants to merge 1 commit into
developmentfrom
bugfix-13968-filter-for-date-in-case-directory-not-working-properly

Conversation

@KarnaiahPesula

@KarnaiahPesula KarnaiahPesula commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

…ort date search.

Fixes #

Summary by CodeRabbit

  • New Features

    • Case date filtering now uses the report date by default.
    • Deprecated case date options are excluded from available selections.
  • Improvements

    • Updated the case date prompt to display “Case report date.”
    • Improved handling of deprecated date types across case filtering.

@KarnaiahPesula KarnaiahPesula linked an issue Jul 21, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dd57ec8f-1c42-418d-b32c-7cb3f592667c

📥 Commits

Reviewing files that changed from the base of the PR and between 6e8ec48 and 17b0b23.

📒 Files selected for processing (5)
  • sormas-api/src/main/java/de/symeda/sormas/api/caze/NewCaseDateType.java
  • sormas-api/src/main/java/de/symeda/sormas/api/utils/criteria/CriteriaDateTypeHelper.java
  • sormas-api/src/main/java/de/symeda/sormas/api/utils/fieldaccess/FieldAccessCheckers.java
  • sormas-api/src/main/resources/strings.properties
  • sormas-ui/src/main/java/de/symeda/sormas/ui/caze/CaseFilterForm.java

📝 Walkthrough

Walkthrough

MOST_RELEVANT is deprecated and excluded from criteria date type lists. Case filtering now defaults missing date selections to REPORT, removes a date label argument, and updates the related prompt text.

Changes

Case date type changes

Layer / File(s) Summary
Deprecation and filtering
sormas-api/src/main/java/de/symeda/sormas/api/caze/NewCaseDateType.java, sormas-api/src/main/java/de/symeda/sormas/api/utils/fieldaccess/FieldAccessCheckers.java, sormas-api/src/main/java/de/symeda/sormas/api/utils/criteria/CriteriaDateTypeHelper.java
MOST_RELEVANT is marked deprecated, and deprecated enum values are filtered from generated criteria date type lists.
Case filter date handling
sormas-ui/src/main/java/de/symeda/sormas/ui/caze/CaseFilterForm.java, sormas-api/src/main/resources/strings.properties
Case filtering defaults a null date type to REPORT, omits the previous date label argument, and changes the prompt text to “Case report date”.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete and does not provide a valid issue reference or a clear summary beyond a fragment. Add the missing issue number after 'Fixes #' and include a short description of the change and its impact.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: removing the case reference date filter and defaulting report date search.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix-13968-filter-for-date-in-case-directory-not-working-properly

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter for date in case directory not working properly

2 participants