Skip to content

Fixed the persons dob search issue. If filter not a partial search, l… - #14235

Open
KarnaiahPesula wants to merge 1 commit into
developmentfrom
bugfix-13706-include-partial-birthdates-checkbox-does-nothing-persons-directory
Open

Fixed the persons dob search issue. If filter not a partial search, l…#14235
KarnaiahPesula wants to merge 1 commit into
developmentfrom
bugfix-13706-include-partial-birthdates-checkbox-does-nothing-persons-directory

Conversation

@KarnaiahPesula

@KarnaiahPesula KarnaiahPesula commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

…ooking for a valid complete dob, otherwise including partial dobs.

Fixes #

Summary by CodeRabbit

  • Bug Fixes
    • Improved full-date birthdate filtering to exclude records with incomplete birthdate information.
    • Ensured date range searches evaluate only records with year, month, and day values present.

…ooking for a valid complete dob, otherwise including partial dobs.
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3c1acc2f-9964-44f8-8523-1d152976b6dc

📥 Commits

Reviewing files that changed from the base of the PR and between 6e8ec48 and c613ced.

📒 Files selected for processing (1)
  • sormas-backend/src/main/java/de/symeda/sormas/backend/util/BirthdateRangeFilterPredicate.java

📝 Walkthrough

Walkthrough

Full birthdate range filtering now requires non-null year, month, and day components. Both lower-bound and upper-bound predicates apply the existing date comparisons only to records with complete birthdates.

Changes

Birthdate range filtering

Layer / File(s) Summary
Require complete birthdates for range checks
sormas-backend/src/main/java/de/symeda/sormas/backend/util/BirthdateRangeFilterPredicate.java
Adds a complete-birthdate predicate and combines it with the existing birthdateFrom and birthdateTo full-date range conditions.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete because it does not provide the required issue number after "Fixes #". Add the related issue number after "Fixes #" and keep the summary concise and complete.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change by describing the persons DOB search fix and the partial-search behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix-13706-include-partial-birthdates-checkbox-does-nothing-persons-directory

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include partial birthdates checkbox does nothing - Persons directory

2 participants