Fix mesh warp failure on patches joined to the surface at a single vertex - #2620
Merged
Conversation
…rtex repair_mesh extracted the largest component with vtkPolyDataConnectivityFilter, which counts a shared corner as connected, and ran it before remove_zero_area_triangles, which can strand patches of its own. igl::biharmonic_coordinates joins faces by edge, so it saw those as separate components and failed. Add MeshUtils::extract_largest_edge_connected_component, run at the end of repair_mesh instead. Also return early from check_warp_ready once a warp has failed, so queued meshes don't each repeat it. Fixes #2619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2619
repair_meshextracted the largest component using point connectivity and did so beforeremove_zero_area_triangles, so patches joined to the surface at a single vertex survived andigl::biharmonic_coordinatesfailed on them. Adds an edge-connected extraction at the end ofrepair_mesh, and stops an already-failed warp being regenerated once per queued mesh.Two new MeshTests cases. Mesh, Groom, Optimize, Image, Particles and Project suites pass.