Add Event Edit Page

[KhoaNguyen706]

I changed these:

• add Event Edit page ( just the same format with create page)
• add the little button edit on the top right corner
• Temporarily grant Admin permission for create and update event
• Authorization will add later
• currently enable the SCE events
  Before:

We can edit registeration form too: after update event:

[steeevin88]

did you test this? could you include screenshots

[KhoaNguyen706]

Yes, I did, It worked for mock data

[steeevin88]

left a few comments, in general though im confused why we have mock functions? as opposed to testing with actual Clark

i know it'll take a few extra steps to create the account in local Clark, create event, etc... but i'd prefer to be extra and ensure things work

also, i don't think any of this stuff is gated. remember that anything SCEvents related on Clark shouldn't be made public yet... so we need to ensure your new page is gated. (even though technically it's true that accessing this page is hard b/c you'd need access to the gated Events page... we should still be thorough)

[steeevin88]

besides one more comment this LGTM!

just to make sure, this is gated right? if so feel free to merge

[steeevin88]

remove this

[steeevin88]

i think the edit event page isn't gated, let's add this:

...
const isSCEventsEnabled = config.SCEvents?.ENABLED;
...
  if (!isSCEventsEnabled) {
    return <Redirect to="/notfound" />;
  }

similar to this:

Clark/src/Pages/Events/Events.js

Lines 135 to 168 in 60fc7d4

	export default function EventsPage() {
	const { user } = useSCE();
	const [events, setEvents] = useState([]);
	const [isLoading, setIsLoading] = useState(true);
	const [hasError, setHasError] = useState(false);
	const isSCEventsEnabled = config.SCEvents?.ENABLED;
	const canCreateEvent = user?.accessLevel >= membershipState.OFFICER;
	useEffect(() => {
	if (!isSCEventsEnabled) {
	return;
	}
	async function fetchEvents() {
	setIsLoading(true);
	setHasError(false);
	const response = await getAllSCEvents();
	if (!response.error) {
	setEvents(Array.isArray(response.responseData) ? response.responseData : []);
	} else {
	setHasError(true);
	}
	setIsLoading(false);
	}
	fetchEvents();
	}, [isSCEventsEnabled]);
	if (!isSCEventsEnabled) {
	return <Redirect to="/notfound" />;
	}

obviously technically the edit page won't be accessible since the main SCEvents page isn't accessible + there will be no events, but we should be cautious regardless

[steeevin88]

nice

[c1ndytat]

lgtm