Skip to content

fix: use subprocess instead of os.system in extract_sound_samples.py#11

Closed
orbisai0security wants to merge 1 commit into
SAT-R:mainfrom
orbisai0security:fix-shell-injection-extract-sound-samples
Closed

fix: use subprocess instead of os.system in extract_sound_samples.py#11
orbisai0security wants to merge 1 commit into
SAT-R:mainfrom
orbisai0security:fix-shell-injection-extract-sound-samples

Conversation

@orbisai0security
Copy link
Copy Markdown

Summary

Fix high severity security issue in scripts/sound/extract_sound_samples.py.

Vulnerability

Field Value
ID V-001
Severity HIGH
Scanner multi_agent_ai
Rule V-001
File scripts/sound/extract_sound_samples.py:8

Description: The script constructs a shell command by directly concatenating the filepath variable into an os.system() call without any sanitization or validation. When the script iterates over files in a directory (e.g., via os.listdir or glob), an attacker can place a file with a maliciously crafted name containing shell metacharacters in the scanned directory to achieve arbitrary command execution with the privileges of the running process.

Changes

  • scripts/sound/extract_sound_samples.py

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

Automated security fix generated by Orbis Security AI
@JaceCear
Copy link
Copy Markdown
Contributor

It's just a script to export samples, it's not actively used.

Also we have a strict no-AI / LLM code policy. See the sa2 readme for that.

@JaceCear JaceCear closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants