fix: use subprocess instead of os.system in extract_sound_samples.py#11
Closed
orbisai0security wants to merge 1 commit into
Closed
Conversation
Automated security fix generated by Orbis Security AI
Contributor
|
It's just a script to export samples, it's not actively used. Also we have a strict no-AI / LLM code policy. See the sa2 readme for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
scripts/sound/extract_sound_samples.py.Vulnerability
V-001scripts/sound/extract_sound_samples.py:8Description: The script constructs a shell command by directly concatenating the filepath variable into an os.system() call without any sanitization or validation. When the script iterates over files in a directory (e.g., via os.listdir or glob), an attacker can place a file with a maliciously crafted name containing shell metacharacters in the scanned directory to achieve arbitrary command execution with the privileges of the running process.
Changes
scripts/sound/extract_sound_samples.pyVerification
Automated security fix by OrbisAI Security