-
Notifications
You must be signed in to change notification settings - Fork 57
BriBaSA_ex crash fixes #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f3f2f1d
042ea79
e2a9367
f637de7
1760d8d
3011aa5
ce06af4
8c0e0c0
3e0b56a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,9 @@ | |
| Thumbs.db | ||
| ehthumbs.db | ||
|
|
||
| # RAD Debugger files | ||
| *.rdi | ||
|
|
||
| # Visual Studio folder | ||
| .vs | ||
| *.pdb | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| #ifndef GUARD_CONSTANTS_CHARACTERS_H | ||
| #define GUARD_CONSTANTS_CHARACTERS_H | ||
|
|
||
| #if 01 | ||
| typedef enum { | ||
| CHARACTER_SONIC, | ||
| #if (GAME >= GAME_SA2) | ||
|
|
@@ -12,6 +13,15 @@ typedef enum { | |
|
|
||
| NUM_CHARACTERS | ||
| } ECharacters; | ||
| #else | ||
| // TODO: Right now these have to be defined like this for BriBaSA_ex to work. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Btw since we have
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I mean, moving it to a different file would be unintuitive... But overall it's definitely better to have an enum than
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree enum is better, but atm we have both lol |
||
| // Obviously this shall change! | ||
| #define CHARACTER_SONIC 0 | ||
| #define CHARACTER_TAILS 1 | ||
| #define CHARACTER_KNUCKLES 2 | ||
| #define CHARACTER_AMY 3 | ||
| #define NUM_CHARACTERS 4 | ||
| #endif | ||
|
|
||
| // NOTE: Put this after NUM_CHARACTERS, to allow BriBaSA_ex to parse this file properly. | ||
| // Naming it CHARACTER_<something> before NUM_CHARACTERS confuses it. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| #ifndef GUARD_BRIBASA_EX_FILE_PATHS_H | ||
| #define GUARD_BRIBASA_EX_FILE_PATHS_H | ||
|
|
||
| extern void InitFilePaths(FileInfo *outInfo, char *gameDir, char *mapDir); | ||
| extern void InitFilePaths(Game game, FileInfo *outInfo, char *gameDir, char *mapDir); | ||
| extern char *allocPath(char *folder, char *fileName); | ||
|
|
||
| #endif // GUARD_BRIBASA_EX_FILE_PATHS_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?