Skip to content

ci: skip integration tests completely for all PRs - #94

Merged
ZhongpinWang merged 2 commits into
mainfrom
disable-integration-tests-on-pr-level
Aug 26, 2026
Merged

ci: skip integration tests completely for all PRs#94
ZhongpinWang merged 2 commits into
mainfrom
disable-integration-tests-on-pr-level

Conversation

@ZhongpinWang

Copy link
Copy Markdown
Contributor

Currently, the integration tests (which are actually hundreds of e2e tests) are running for hours and triggered by each commit in any PRs.

Disabling it and only run it on the main branch.

Later on we should consider refactor e2e tests and leveraging the new sample code package.

@ZhongpinWang
ZhongpinWang requested a review from mwien August 26, 2026 07:27
@ZhongpinWang
ZhongpinWang requested a review from alpkom as a code owner August 26, 2026 07:27
@mwien

mwien commented Aug 26, 2026

Copy link
Copy Markdown

To be precise, only the integration tests for gen take hours, the others take minutes. Also only the ones for gen currently fail currently as far as I can tell. So that's an argument for only disabling gen for now.

@ZhongpinWang

Copy link
Copy Markdown
Contributor Author

To be precise, only the integration tests for gen take hours, the others take minutes. Also only the ones for gen currently fail currently as far as I can tell. So that's an argument for only disabling gen for now.

Yes your are right. I was only thinking if all tests should be sent to the remote server over network without having any mock server. Many integration tests also just check the shape of the response. Once we adopt the generation approach, even this won't be necessary. So we can keep them for now and I added base and core back. But in long term there are much room for improvement.

@ZhongpinWang
ZhongpinWang merged commit 4ab1091 into main Aug 26, 2026
17 checks passed
@ZhongpinWang
ZhongpinWang deleted the disable-integration-tests-on-pr-level branch August 26, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants