Skip to content

Remove JDK requirement from README #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finkmanAtSap merged 3 commits into from
Jul 28, 2026
Merged

Remove JDK requirement from README #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f2e908
Remove JDK requirement from README
finkmanAtSap Jul 27, 2026
4971053
Merge branch 'main' into remove_jdk_from_readme
finkmanAtSap Jul 27, 2026
c795fea
always run checks for quality gate
finkmanAtSap Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/build_and_test_cap.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,11 @@ permissions:
contents: read

on:
workflow_dispatch:
push:
branches: [ "main" ]
paths:
- "ams-cap-nodejs-bookshop/**"
- ".github/workflows/build_and_test_cap.yml"
pull_request:
branches: [ "**" ]
paths:
- "ams-cap-nodejs-bookshop/**"
- ".github/workflows/build_and_test_cap.yml"

jobs:
npm:
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/build_and_test_expressjs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,11 @@ permissions:
contents: read

on:
workflow_dispatch:
push:
branches: [ "main" ]
paths:
- "ams-express-shopping/**"
- ".github/workflows/build_and_test_expressjs.yml"
pull_request:
branches: [ "**" ]
paths:
- "ams-express-shopping/**"
- ".github/workflows/build_and_test_expressjs.yml"

jobs:
npm:
Expand Down
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ When deployed, authorization policies are managed in the SCI administration cock

## Requirements
- a Node.js LTS version that is at least [in maintenance](https://nodejs.org/en/about/previous-releases)
- a JDK 17+ for local DCL compilation before unit tests

## How to obtain support
For bugs and issues of the sample applications themselves or questions about the content, please [create an issue](https://github.com/SAP-samples/ams-samples-node/issues) in this repository.
Expand Down