Clamp the default buffer size to what the device supports - #914
Open
benface wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_devicepicks a 50 ms buffer without checking what the device accepts. My AirPods only take 15–960 frames, so it asks for 2048, and cpal 0.18 refuses a fixed size outside the supported range — the stream never opens.open_default_sinkthen walks the other devices and takes the first that opens. On my machine that's a virtual output from a screen recorder, so the audio plays somewhere nobody can hear. That part surprised me more than the failure itself.The range is already in
default_config, so this clamps to it.OutputConfig::fromin the speakers API does the same thing, just spelled out over four match arms.Might be #900 as well — same "worked on crates.io, unsupported device on master" shape, on Windows.