Skip to content

Windows: Fix drag mouse position for parented windows (bugfix) #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexCharlton wants to merge 4 commits into
base: master
Choose a base branch
from
+19 −2
Open

Windows: Fix drag mouse position for parented windows (bugfix) #253

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd0d3a4
Win: Fix drag mouse position for parented windows
AlexCharlton May 23, 2026
111d4a3
Fix inconsistent scale
AlexCharlton May 26, 2026
0da2ffd
Revert
AlexCharlton Jun 19, 2026
e0dce59
DPI scaling before and after ScreenToClient
AlexCharlton Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/platform/win/drop_target.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ use windows::Win32::System::Ole::*;
use windows::Win32::System::SystemServices::MODIFIERKEYS_FLAGS;
use windows_core::Ref;
use windows_sys::Win32::{
Foundation::POINT, Graphics::Gdi::ScreenToClient, UI::Shell::DragQueryFileW,
Foundation::POINT,
Graphics::Gdi::ScreenToClient,
UI::{
HiDpi::{LogicalToPhysicalPointForPerMonitorDPI, PhysicalToLogicalPointForPerMonitorDPI},
Shell::DragQueryFileW,
},
};

use crate::{DropData, DropEffect, Event, EventStatus, MouseEvent, PhyPoint, Point};
Expand Down Expand Up @@ -63,7 +68,19 @@ impl DropTarget {
return;
};
let mut pt = POINT { x: pt.x, y: pt.y };
unsafe { ScreenToClient(window_state.hwnd, &mut pt as *mut POINT) };

// ScreenToClient isn't DPI-aware
if unsafe { PhysicalToLogicalPointForPerMonitorDPI(null_mut(), &mut pt) == 0 } {
return;
}

if unsafe { ScreenToClient(window_state.hwnd, &mut pt) == 0 } {
return;
}

if unsafe { LogicalToPhysicalPointForPerMonitorDPI(null_mut(), &mut pt) == 0 } {
return;
}
let phy_point = PhyPoint::new(pt.x, pt.y);
self.drag_position.set(phy_point.to_logical(&window_state.window_info()));
}
Expand Down