gccrs: add while true lint - #4622
Open
lucasly-ba wants to merge 1 commit into
Open
Conversation
lucasly-ba
force-pushed
the
while-true
branch
2 times, most recently
from
June 29, 2026 22:18
983b784 to
4a8f0b3
Compare
CohenArthur
reviewed
Jun 30, 2026
CohenArthur
left a comment
CohenArthur
left a comment
Member
There was a problem hiding this comment.
the implementation LGTM but just check the flag, I don't know that we want these warnings to be disabled if someone passes -Wno-unused-variable
P-E-P
reviewed
Jul 1, 2026
lucasly-ba
force-pushed
the
while-true
branch
5 times, most recently
from
July 9, 2026 13:35
4e04d65 to
97da3f2
Compare
gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (BoolLiteral): New. (ConstantTruth): New. (UnusedChecker::visit): New. * checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit): New. * rust-lang.cc (grs_langhook_init_options_struct): Enable warn_unused. gcc/testsuite/ChangeLog: * rust/compile/while-true_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
Contributor
Author
Contributor
Author
|
Should be good @P-E-P @CohenArthur |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the while true lint, which warns when a while loop uses the literal
trueas its condition and suggests usingloopinstead.gcc/testsuite/ChangeLog: