Make books use PTX generate templates for student pages by default - #1336
Merged
bnmnetp merged 2 commits intoAug 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the default behavior for the use_pretext_student_pages course attribute so that student pages use the PreTeXt-generated templates by default, and centralizes the “string is true” coercion logic in a shared CRUD helper.
Changes:
- Added
course_attr_is_true()helper to interpret course attribute values as booleans. - Updated book, assignment-student, and admin-instructor routers to use the helper and default
use_pretext_student_pagestoTrue. - Exported the new helper via
rsptx.db.crudfor reuse.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| components/rsptx/db/crud/course_attrs.py | Adds a shared boolean-coercion helper for course attributes. |
| components/rsptx/db/crud/init.py | Re-exports the new helper from the CRUD package. |
| bases/rsptx/book_server_api/routers/course.py | Switches use_pretext_student_pages detection to the helper and defaults it on. |
| bases/rsptx/assignment_server_api/routers/student.py | Switches use_pretext_student_pages detection to the helper and defaults it on (two call sites). |
| bases/rsptx/admin_server_api/routers/instructor.py | Makes the admin course settings view default the toggle on via the helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ascholerChemeketa
force-pushed
the
default-ptx-pages-true
branch
from
August 1, 2026 17:42
2062fab to
7516bf1
Compare
bnmnetp
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.