Skip to content

AUTH-006I — Hand off profile Edit focus to the full-name input - #656

Merged
daliu merged 1 commit into
mainfrom
codex/issue-655-profile-edit-input-focus
Aug 14, 2026
Merged

AUTH-006I — Hand off profile Edit focus to the full-name input#656
daliu merged 1 commit into
mainfrom
codex/issue-655-profile-edit-input-focus

Conversation

@daliu

@daliu daliu commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Closes #655

Officer impact: No live officer workflow changes. In reviewed My Account source, a keyboard user whose exact current focused Edit opens the full-name editor receives one otherwise-lost focus handoff to the existing Full name input. Unfocused or programmatic Edit activation opens the same editor without moving focus.

Officer documentation: SYSTEM_DESIGN.md, IMPLEMENTATION_PLAN.md, SECURITY.md, and the existing My Account diagram/text alternative plus one no-terminal source-evidence procedure in docs/officers/EVENTS_SHOP_MEMBERS.md.

Deployment evidence: Source and synthetic tests only at PR creation. No website publication, runmprc.com change, Firebase deployment, provider configuration, account/sign-in action, production-data action, or live behavior is claimed. Directory availability remains byte-for-byte false, and the published site remains the inert #623 boundary.

Outcome

  • Records only the opaque current profile generation when the exact connected Edit event target owns focus.
  • Consumes the intent before every check in one layout effect.
  • Requires the mounted, matching application/Firestore/identity/UID context, ready profile, open editor, no save in progress, and the exact connected enabled input.
  • Restores only absent, body, document-root, or disconnected focus; preserves every other connected focus; never retries on a later render.
  • Leaves the existing native controls, current name, accessible description, autocomplete, maximum length, DOM order, global focus styling, validation, payloads, reads, writes, and AUTH-006F/G/H behavior unchanged.
  • Adds no React state, autoFocus, timeout, animation frame, CSS, service call, log, storage, backend, provider, or data path.

Exact candidate

  • Commit: 1ea34dc836c6075e08b8353049c8a5a97fc9d364
  • Tree: 322468cc75a57f7ea392eb9f57a201fb11c4b35a
  • Base: 75a4f1ee3b20f61d375ed6d786e67e056a2206ef
  • Exact six-path binary diff SHA-256: 27106fa69f77a0fcfb86598cfbeb725b03f096194e61f988cdfcdb58a7d43b11
  • Runtime diff SHA-256: a5bddd143b62af06b2357b30f3045117009b3bc827b1753bbb7a34f6c42cd5b4
  • Test diff SHA-256: b5966220783abca0c5cfed832752471f167f0dcf48d636ab2eafd2c07896c3f3
  • Docs diff SHA-256: 1bf2e826d93d70e880c173c805122590b04ca4c1516e6966f7c94c165e6bb220

Evidence

  • Trustworthy unchanged-runtime RED: 1 failed / 288 skipped / 289 total, failing only because focus remained on body; test-only SHA-256 3de742e72b8ef0d847c0a5811da0000631ecd926dcd1e9e5c589932e9b78efb4.
  • AUTH-006I: 17/17 passed.
  • Full Account: 305/305 passed.
  • Full frontend: 18/18 suites, 1,314/1,314 tests passed on Node 20.20.2.
  • Repository Node checks: 105/105 passed on Node 20.20.2.
  • TypeScript --noEmit: passed.
  • Scoped ESLint: passed with zero output.
  • Frontend lint baseline: passed for 120 files, preserving 113 reviewed legacy errors and 6 reviewed legacy warnings.
  • Diagnostic production build: passed.
  • git diff --check: passed.
  • Independent runtime/design, frontend/accessibility, security/privacy/race, and backup-officer/operations reviews: GO with no actionable findings.

The defensive missing/disabled-target and lifecycle-clear guards were source-reviewed. React commits this synchronous editor transition and its layout effect together, so the test matrix does not manufacture an unreachable pre-effect interleaving merely to touch those guards.

Preserved boundaries

Hosted evidence is terminal on the exact candidate. CI run 31772669088 passed all five jobs: frontend lint/build/tests/workflow validation, artifact scrubber, Functions lint/tests, Firestore Rules emulator tests, and commerce journal emulator tests. Netlify deploy-preview 6a7ea5873cb0460008ac80bd is ready at exact commit 1ea34dc836c6075e08b8353049c8a5a97fc9d364, review #656, context deploy-preview, and published_at: null; root and /account return x-robots-tag: noindex. Header and redirect checks passed, the Pages-changed check is neutral as expected, and Netlify reports no Functions or edge functions. This unpublished preview is not production evidence; the published pointer remains #623.

@netlify

netlify Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit 1ea34dc
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a7ea5873cb0460008ac80bd
😎 Deploy Preview https://deploy-preview-656--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AUTH-006I — Hand off profile Edit focus to the full-name input

1 participant