Skip to content

MEMBERS-DIRECTORY-001G — Clear People-finder results and distinguish unavailable photos - #632

Merged
daliu merged 1 commit into
mainfrom
codex/issue-631-directory-clear-results
Aug 13, 2026
Merged

MEMBERS-DIRECTORY-001G — Clear People-finder results and distinguish unavailable photos#632
daliu merged 1 commit into
mainfrom
codex/issue-631-directory-clear-results

Conversation

@daliu

@daliu daliu commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Closes #631.

Officer impact: No live duty changes. The preserved future People finder now provides an explicit local Clear action after completed states, and it distinguishes a genuinely absent voluntary photo from a supplied thumbnail that the browser could not display.

Officer documentation: SYSTEM_DESIGN.md, IMPLEMENTATION_PLAN.md, SECURITY.md, and the optional-directory diagram, one-sentence text alternative, and backup-officer source-evidence procedure in docs/officers/EVENTS_SHOP_MEMBERS.md.

Deployment evidence: Source/tests only. memberDirectoryAvailability.ts remains byte-for-byte false; production remains the inert #623 deploy 6a7e072f8f346b0008510d29. No website publication, Firebase, Rules, indexes, Functions, provider configuration, sign-in, account, production-data, or live connected behavior was performed. #507 retains every connection/release gate.

Outcome

  • Keep No photo only for a null photo value.
  • Replace a failed supplied thumbnail with truthful Photo unavailable copy and remove its image/data URL from the rendered page.
  • Give a different later photo version a fresh render attempt.
  • Let an officer locally clear completed validation, empty, fixed-failure, or result-card state, restore focus to the name input, and receive a polite announcement with zero new request ID or service call.
  • Preserve the disabled zero-call default, existing guards/fences, bounded name-only search, and the explicit exclusion of photo search, face recognition, biometrics, totals, exports, or roster authority.

Verification

  • Trustworthy RED: 7 new contract failures / 18 existing passes.
  • Focused Jest: 25/25 passed.
  • Full frontend Jest: 18 suites / 1,116 tests passed after clean lockfile install.
  • TypeScript --noEmit: passed.
  • Frontend lint baseline: 120 files / 113 reviewed legacy errors / 6 reviewed legacy warnings, unchanged.
  • Diagnostic production build: passed.
  • Workflow/security/SPA Node suites: 105/105 passed.
  • Release workflow suite: 14/14 passed.
  • git diff --check: passed.
  • Independent security/privacy, frontend/accessibility/mobile, and backup-officer/operations reviews: GO with no remaining findings.

Exact reviewed head: b1cb1f65ab0793d492d5b042d1c54b7ef712b1a7
Exact tree: fdccc159e1ce2c0f9e0d4297dfa4f3b8b5c2ebc7
Exact base: 03d197a6b156deaa6760d04d1dd35f587aae85f4
Exact seven-path binary diff SHA-256: 7dad2d41af360ae97d51cfaef2add30aceacdd0520993dca4493c697bf37a3c6

@netlify

netlify Bot commented Aug 13, 2026

Copy link
Copy Markdown

Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit b1cb1f6
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a7e341eefa31b00075ec5ec
😎 Deploy Preview https://deploy-preview-632--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@daliu
daliu merged commit d5a218a into main Aug 13, 2026
9 checks passed
@daliu
daliu deleted the codex/issue-631-directory-clear-results branch August 13, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MEMBERS-DIRECTORY-001G — Clear People-finder results and distinguish unavailable photos

1 participant