Skip to content

MEMBERS-DIRECTORY-001E — Harden profile and People-finder interfaces - #628

Merged
daliu merged 1 commit into
mainfrom
codex/issue-627-directory-interface-hardening
Aug 13, 2026
Merged

MEMBERS-DIRECTORY-001E — Harden profile and People-finder interfaces#628
daliu merged 1 commit into
mainfrom
codex/issue-627-directory-interface-hardening

Conversation

@daliu

@daliu daliu commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Outcome

Hardens the preserved profile-photo and People finder interfaces while keeping the backend availability boundary unchanged at false.

  • Uses the server projection's exact bounded Unicode name eligibility for new opt-in, while preserving opt-out.
  • Adds control-linked errors, no-photo image semantics, non-counting search completion status, explicit readable colors, 44px controls, and 320px containment.
  • Fences delayed file reads across application/account changes.
  • Adds focused regression coverage and updates the source-only directory design and officer review procedure.
  • Keeps name search plus voluntary thumbnails; adds no photo query, facial recognition, embedding, similarity, or biometric behavior.

Related: #627

Officer impact: Officers get no new live duty or connected search. The reviewed source is more accessible and resilient, but the public #623 preview remains inert and the complete feature remains NOT AVAILABLE YET.

Officer documentation: docs/officers/EVENTS_SHOP_MEMBERS.md updates the source-only review procedure, Mermaid diagram, text alternative, stop conditions, evidence separation, and #507 handoff. Root design/security/current-plan records are also updated.

Deployment evidence: Source only. The availability constant remains byte-identical false; no website publication, Firebase/Rules/index/Function deployment, provider configuration, account/sign-in action, or production-data action was performed. Production remains #623 deploy 6a7e072f8f346b0008510d29. #507 retains connection, privacy approval, scoped authorization, staging, backend-first deployment/readback, availability flip, publication, and live proof.

Verification

  • Full frontend Jest: 18 suites / 1,089 tests passed.
  • Focused directory suites: 3 suites / 312 tests passed.
  • TypeScript tsc --noEmit: passed.
  • Diagnostic production build: passed.
  • Frontend lint baseline: 120 files / 113 reviewed legacy errors / 6 reviewed legacy warnings.
  • CI workflow + SPA navigation tests: 21/21 passed.
  • Release workflow tests: 14/14 passed.
  • git diff --check: passed.
  • Synthetic 320×900 review: no horizontal overflow, readable contrast, 44px controls, stacked search action, and keyboard flow passed.
  • Independent security/privacy, frontend/accessibility/mobile, and backup-officer operations reviews: GO.

Exact reviewed head: 39a283eb143ce9ca3233bbbaf2b1c87a2537420b
Tree: c4866084f8bc407eb4d42122550b9d4a7f87b120
Parent: d09ddb242cc9ec25578c11c6b8f078d10753abd5
Exact 11-file diff SHA-256: 939842fd789894b4569c15feb74c9f35627399c14691067ac5ad02e6347adcef

@netlify

netlify Bot commented Aug 13, 2026

Copy link
Copy Markdown

Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit 39a283e
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a7e1a1266c9050008bceab8
😎 Deploy Preview https://deploy-preview-628--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@daliu
daliu merged commit 1e8fa00 into main Aug 13, 2026
9 checks passed
@daliu
daliu deleted the codex/issue-627-directory-interface-hardening branch August 13, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant