improve human readable output#459
Open
eworm-de wants to merge 6 commits into
Open
Conversation
eworm-de
force-pushed
the
human
branch
2 times, most recently
from
67d6240 to
42238c9
Compare
Contributor
Author
|
As there is a new pre-release... Can I have a quick feedback and state on this? |
Member
|
The current release only has bugfixes in the main code (it's only the adjunct scripts & manpages that got enhancements). I'm very cautious in making output-affecting changing, but will be giving this a closer look. |
Contributor
Author
|
I can understand you are cautious about making output-affecting changing, guess this is due to breaking scripts that expect specific output? |
Member
|
@eworm-de could you add a description of the before and after of what this change does? Needs a bit more context than "improve" :-) |
Contributor
Author
|
The commit messages have the details. Are you missing something there or just here in the pull request? |
eworm-de
force-pushed
the
human
branch
2 times, most recently
from
933dc1f to
75ea671
Compare
Contributor
Author
|
This is the output of |
Member
eworm-de
force-pushed
the
human
branch
3 times, most recently
from
0ca5744 to
6abcd9b
Compare
Contributor
Author
|
Just added another commit: |
eworm-de
force-pushed
the
human
branch
2 times, most recently
from
a20c3e6 to
cb0b932
Compare
Contributor
Author
I still stand by my point: This is about human readable output. We should not be worried too much about compatibility with parsers. |
Contributor
Author
|
Any news on this? Does it help if I split this across several pull requests? |
eworm-de
force-pushed
the
human
branch
2 times, most recently
from
9bcdb1b to
050399c
Compare
eworm-de
force-pushed
the
human
branch
3 times, most recently
from
46d2d98 to
a5a0fa6
Compare
eworm-de
force-pushed
the
human
branch
2 times, most recently
from
8a3cf64 to
d6590e2
Compare
eworm-de
force-pushed
the
human
branch
4 times, most recently
from
bfd68be to
3c73315
Compare
eworm-de
force-pushed
the
human
branch
6 times, most recently
from
bbe72ad to
1ce460f
Compare
eworm-de
force-pushed
the
human
branch
4 times, most recently
from
92ae807 to
0a8a9a1
Compare
eworm-de
force-pushed
the
human
branch
2 times, most recently
from
3f15dd9 to
f277657
Compare
eworm-de
force-pushed
the
human
branch
3 times, most recently
from
677d70d to
8a2efa4
Compare
This drops a lot of `else if` blocks and extends units by "E" (Exa), which is 2^60 and thus the last to fit into int64.
Let's lower precision for huge numbers. The output used to be: 3.45M -> 46.73M -> 523.11M -> 1.24G -> ... With this change the code always gives the three most significant digits: 3.45M -> 46.7M -> 523M -> 1.24G -> ...
... just make sure no precision is added.
Let's also simplify the code for rate in progress, and benefit from same functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculate in a loop, use dynamic precision.