[Refactor] Share create GitHub App form across setup and settings#70
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Refactor] Share create GitHub App form across setup and settings#70roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Extract CreateGitHubAppManifestForm so settings and onboarding use one manifest create flow instead of near-duplicate local implementations.
Contributor
Author
|
No code issues found. See task |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Settings and onboarding no longer each own a near-copy of the Create GitHub App flow. Both surfaces now use one shared form component for the organization field, create CTA, and GitHub App manifest POST handoff, while keeping their existing layout, copy, redirects, and manual-entry paths.
Why this change was made
PR #51 reintroduced a settings-side Create GitHub App implementation that duplicated onboarding’s setup step. That left two sources of truth for the same flow, so org handling, redirects, and pending states could drift.
Impact
No intended user-facing behavior change. Fixing or improving Create GitHub App once now applies to both onboarding and Settings, which reduces the risk of inconsistent setup UX after future changes.