[Refactor] Collapse Microsoft setup dual-write to single ownership#24
Draft
roomote-roomote-v1[bot] wants to merge 1 commit into
Draft
Conversation
Store only ROOMOTE_AUTH_MICROSOFT_* during setup; runtime already falls back from those credentials for the Teams bot without a second write.
Author
|
2 issues outstanding. See task
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Microsoft Teams setup now stores only the Microsoft sign-in credentials for the single-app path. Dedicated Teams bot env vars are no longer copied client-side on save; setup treats them as optional dual-app overrides, and the bot continues to fall back to the Microsoft app values at runtime.
Why this change was made
Runtime already reuses Microsoft sign-in credentials when no dedicated bot pair is configured. Dual-writing a second ownership layer during setup made setup harder to reason about and stored redundant secrets without adding capability.
Impact
Operators finishing Microsoft setup only save one app registration. Existing installations with dedicated bot credentials keep working, and Settings or env vars can still set optional bot overrides when a deployment intentionally uses a separate bot app.