[Feat] Canonical @roomote mention alias on GitHub#239
Draft
mrubens wants to merge 3 commits into
Draft
Conversation
Contributor
|
No new code issues found. See task Re-reviewed the only new commit since the last review ( Reviewed 41313c5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product decision: user-facing copy always advertises
@roomote, and every deployment listens for both@roomoteand its own configured GitHub App slug. Roo Code owns theroomoteGitHub App and user, so the alias cannot be claimed by a third party.isMentionmatches the canonical alias or the effective slug, keeping the word-boundary semantics from [Fix] Require word boundaries when matching GitHub app mentions #238.@roomote(newROOMOTE_CANONICAL_GITHUB_MENTIONconstant) instead of the deployment slug.R_GITHUB_DISABLE_CANONICAL_MENTION=trueopts a deployment out: it stops answering bare@roomoteand its footers advertise its own slug again. For fleets where several deployments share the same repositories (e.g. nightly + preview on one org) so a bare@roomotedoesn't make all of them respond. Documented on the GitHub provider docs page.normalizePrBodyAttributionAppMention) and its slug-resolution helper (resolveConfiguredGitHubAppSlugIfConfigured) are obsolete and removed, along with their tests and the sdk call site.ROOMOTE_GITHUB_HOSTED_APP_SLUGSfreshened.Setup flow is untouched: it already suggests
roomote-<host>at app creation and shows the deployment's real handle in invoke-method copy, which stays correct alongside the alias.Validation: targeted suites green across env (65), github (31), api, sdk, and the full cloud-agents workflow suite; check-types clean on all affected packages; prettier and knip clean.